-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed conflicts between inline policy and policy_arns, updated tests #344
removed conflicts between inline policy and policy_arns, updated tests #344
Conversation
Are there any concerns on getting this merged? Would really like to get this done. |
Hi @mliang2 ! I see you're right that they can be provided together, thanks for catching this. When I run the tests against the current branch of Vault master, I get this:
Can you post the version of Vault you're testing against, as well as the test output you're seeing for these? |
My fork was out of date w/ master. Once I synced w/ master, |
Turns out I was not testing w/ my AWS key set, so those tests were skipped; I'll look into how I can fix this |
@tyrannosaurus-becks This errors you're seeing should fixed. It was caused by me putting the wrong order of the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mliang2 fantastic! The tests are working for me now too. Thank you!
removed conflicts between inline policy and policy_arns, updated tests
It's ok to have
policy_document
andpolicy_arns
defined at the same time for thevault_aws_secret_backend_role
provider.CLI equalivent: